feat: yank replica service and move methods to RPC service#2113
Merged
Conversation
SantiagoPittella
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the block and proof subscription streams from a dedicated gRPC service on the store, to the public RPC service and the store's RPC service.
The public RPC service simply proxies to the store.
In addition I've added the current committed/proven tip to the stream items so that the caller knows how in-sync they currently are. @SantiagoPittella this should help with the ntx sync.
@sergerad this will conflict with your on-going work in #2102 but should maybe simplify your protobuf concerns?
Closes #2112